-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: please consider not setting upper bounds on dependencies #10492
Comments
We can probably do this for pyarrow. IIRC pyarrow releases don't often break Ibis, we're not using that much of its API, and the parts we are using have been around for years. Doing this for every dependency is not something we should do, given that some of them regularly break Ibis (e.g., sqlglot) and require us to write compatibility code to work around the breakage. |
That would be amazing to at least lift this for pyarrow - we want to update to pyarrow 18 to benefit from the new |
I just wanted to include this sqlglot PR, so I tried to add I hear you on keeping upper bounds when we KNOW that there is an incompatibility. But it looks to me like dependabot was bumping the upper bound to the latest released version. ie it was speculating that all future releases would be incompatible. I suppose that running Is there some other workaround that you know of where I can use |
Yup, same. To quote the article above
I'd appreciate it if could also not cap:
thanks 🙏 |
PyArrow upper bound is also blocking 3.13 support in Kedro-Datasets. Cc @noklam xref #10381 (comment) |
Is your feature request related to a problem?
Ibis currently sets upper bounds on dependencies. E.g. the latest release pins
pyarrow<18
What is the motivation behind your request?
This causes issues in CI. For example here it was blocking upgrading to Python 3.13
Describe the solution you'd like
I'd suggest not setting upper bounds on dependencies, as suggested here https://iscinumpy.dev/post/bound-version-constraints/
What version of ibis are you running?
9.5.0
What backend(s) are you using, if any?
Polars
Code of Conduct
The text was updated successfully, but these errors were encountered: