docs(examples): add hashbytes example #10537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gforsyth
reviewed
Nov 29, 2024
There was a problem hiding this comment.
Thanks @IndexSeek !
My inclination is to leave md2 and md4 without explicit support unless a user requests that functionality. I don't want our inclusion of those options to read as tacit support for using them.
This reverts commit 3d8b6e0.
IndexSeek
changed the title
You're welcome! That makes sense to me; I reverted that commit, so now it's just the hashbytes example. |
gforsyth
approved these changes
Nov 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds non-auto computed documentation example for
hashbytes.Edit: removed previous addition of MD2 and MD4 hashing algorithms and reverted that commit.
Also adds support for MD2 and MD4 hashing algorithms for Microsoft SQL Server's HASHBYTES function.Technically, quoting from the docs:> Beginning with SQL Server 2016 (13.x), all algorithms other than SHA2_256, and SHA2_512 are deprecated.Not sure if it's worth including this portion of the change or not.