Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Backend.load_data #5390

Closed
jcrist opened this issue Jan 31, 2023 · 1 comment · Fixed by #5736
Closed

Deprecate Backend.load_data #5390

jcrist opened this issue Jan 31, 2023 · 1 comment · Fixed by #5736
Labels
ddl Issues related to creating or altering data definitions
Milestone
5.0

Comments

@jcrist
Copy link
Member

jcrist commented Jan 31, 2023

con.load_data is identical to con.create_table with force=True. We should:

  • Deprecate load_data in favor of create_table
  • Rename force to overwrite in create_table to better match the overwrite kwarg in insert.
@jcrist jcrist added the ddl Issues related to creating or altering data definitions label Jan 31, 2023
@cpcloud cpcloud added this to the 5.0 milestone Feb 7, 2023
@cpcloud
Copy link
Member

cpcloud commented Mar 7, 2023

con.load_data is identical to con.create_table with force=True

This isn't quite true. force=True doesn't overwrite if the table exists, it does nothing and leaves the table as is.

However, overwrite will have the create or replace behavior.

@cpcloud cpcloud mentioned this issue Mar 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ddl Issues related to creating or altering data definitions
Projects
None yet
Milestone
5.0
Development

Successfully merging a pull request may close this issue.

feat(api): make create_table uniform cpcloud/ibis
2 participants
@cpcloud @jcrist