Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkbox: aria-checked attribute not set. #605

Closed
brunano21 opened this issue Mar 14, 2016 · 2 comments
Closed

Checkbox: aria-checked attribute not set. #605

brunano21 opened this issue Mar 14, 2016 · 2 comments
Assignees
Labels
Milestone

Comments

@brunano21
Copy link
Contributor

The checkbox widget doesn't set the arribute aria-checked when ticking the box.

Tested on its sample page - Buttons.html.

@wkeese
Copy link
Member

wkeese commented Mar 14, 2016

Looks like <d-checkbox> embeds an <input type=checkbox>, and the focus goes to that node. aria-checked isn't necessary on <input type=checkbox> nodes. It's only a "workaround" for when you have <div> etc. mimicking an <input type=checkbox>. For deliteful, the focus goes to the <input type=checkbox> and therefore aria-checked should be unnecessary.

BTW, I noticed that deliteful is setting aria-disabled and role=checkbox. Both of those are unnecessary too.

@brunano21
Copy link
Contributor Author

According to this (if realiable), when using the role=checkbox, aria-checked is needed.

However, doing some tests with JAWS17, removing role=checkbox from the <input> leaves the widget working fine, as it should. It reacts well when checking/unchecking.

So I would suggest to remove role=checkbox, since it has an implicit role.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants