Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in when: clauses mix of String and boolean comparison #1041

Closed
pohlkamp opened this issue Oct 9, 2023 · 1 comment
Closed
Assignees

Comments

@pohlkamp
Copy link

pohlkamp commented Oct 9, 2023

Issue at client install when deploying client's certificates using the ansible scripts.

The skipping suggests that when: mas_manual_cert_mgmt == True is false.
mas_manual_cert_mgmt: "{{ lookup('env', 'MAS_MANUAL_CERT_MGMT') | default(False, true) }}"

When running it with
export MAS_MANUAL_CERT_MGMT=true it fails, only with 'True' (captal T) it works well. This is not boolean, it's String comparison.

when: mas_manual_cert_mgmt == True

In other scripts it is the other way around, as in

when: install_cp4d_platform == true
stating when: install_cp4d_platform == true

Please correct capital writings in the scripts to avoid interruptions during installs and bring it in line to the standards.

@andrercm
Copy link
Contributor

Should be fixed with this PR: #1114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants