remove rtas_ibm_get_vpd?

[nathanlynch]

As far as I can tell, anything that rtas_ibm_get_vpd can do is better handled by the lsvpd package. rtas_ibm_get_vpd dumps unprintable data to standard output without any sort of decoding:

[root@ltcalpine2-lp9 ~]# rtas_ibm_get_vpd | hexdump -C -n 512 
00000000  00 00 00 9a 82 0a 00 53  79 73 74 65 6d 20 56 50  |.......System VP|
00000010  44 90 89 00 52 54 04 56  53 59 53 46 47 04 58 58  |D...RT.VSYSFG.XX|
00000020  53 56 42 52 02 53 30 59  4c 11 55 38 34 30 38 2e  |SVBR.S0YL.U8408.|
00000030  45 38 45 2e 31 30 41 37  41 43 56 53 45 07 31 30  |E8E.10A7ACVSE.10|
00000040  41 37 41 43 56 54 4d 08  38 34 30 38 2d 45 38 45  |A7ACVTM.8408-E8E|
00000050  53 55 0c 30 30 30 34 41  43 31 42 32 33 31 32 57  |SU.0004AC1B2312W|
00000060  4e 0c 43 30 35 30 37 36  30 38 35 39 32 39 46 56  |N.C05076085929FV|
00000070  20 53 56 38 33 30 5f 30  31 34 00 00 00 00 00 00  | SV830_014......|
00000080  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
00000090  00 56 4b 09 69 70 7a 53  65 72 69 65 73 78 00 00  |.VK.ipzSeriesx..|
000000a0  00 83 82 03 00 43 45 43  90 79 00 52 54 04 56 43  |.....CEC.y.RT.VC|
000000b0  45 4e 46 47 04 58 58 45  56 42 52 02 53 30 59 4c  |ENFG.XXEVBR.S0YL|
000000c0  11 55 37 38 43 37 2e 30  30 31 2e 52 43 48 30 30  |.U78C7.001.RCH00|
000000d0  35 35 53 45 07 52 43 48  30 30 35 35 54 4d 08 37  |55SE.RCH0055TM.7|
000000e0  38 43 37 2d 30 30 31 43  49 10 38 34 30 38 2d 45  |8C7-001CI.8408-E|
000000f0  38 45 20 31 30 41 37 41  43 56 52 4b 10 30 30 30  |8E 10A7ACVRK.000|
00000100  30 30 30 30 30 30 30 30  30 30 30 30 30 46 43 08  |0000000000000FC.|
00000110  37 38 43 37 2d 30 30 31  56 4b 09 69 70 7a 53 65  |78C7-001VK.ipzSe|
00000120  72 69 65 73 78 00 00 00  d6 82 10 00 49 2f 4f 20  |riesx.......I/O |
00000130  42 41 43 4b 50 4c 41 4e  45 20 20 20 90 bf 00 52  |BACKPLANE   ...R|
00000140  54 04 56 49 4e 49 46 47  04 58 58 42 58 59 4c 14  |T.VINIFG.XXBXYL.|
00000150  55 37 38 43 37 2e 30 30  31 2e 52 43 48 30 30 35  |U78C7.001.RCH005|
00000160  35 2d 50 31 43 43 04 32  43 43 39 53 4e 0c 59 41  |5-P1CC.2CC9SN.YA|
00000170  31 30 42 47 34 43 53 30  30 34 43 45 01 31 56 5a  |10BG4CS004CE.1VZ|
00000180  02 30 31 46 4e 07 30 30  45 33 39 36 34 50 4e 07  |.01FN.00E3964PN.|
00000190  37 34 59 34 35 37 36 50  52 10 32 30 30 30 30 30  |74Y4576PR.200000|
000001a0  30 30 30 30 30 30 30 30  30 30 48 45 04 30 30 30  |0000000000HE.000|
000001b0  31 43 54 08 34 30 46 33  30 30 32 35 48 57 04 30  |1CT.40F30025HW.0|
000001c0  30 30 34 42 33 0c 30 30  30 30 30 30 30 30 30 30  |004B3.0000000000|
000001d0  30 31 42 34 02 30 30 42  37 18 30 30 30 30 30 30  |01B4.00B7.000000|
000001e0  30 30 30 30 30 30 30 30  30 30 30 30 30 30 30 30  |0000000000000000|
000001f0  30 30 56 4b 09 69 70 7a  53 65 72 69 65 73 78 00  |00VK.ipzSeriesx.|
00000200

I can't imagine how it would be useful, except as an input to some other program that can actually decode this?

[tyreld]

I'm a little hesitant to just rip this out. While I'm not aware of any Linux consumer I do wonder if this utility can get called by the HMC.

[nathanlynch]

I don't think the HMC uses it (I checked dynamicrm, which calls drmgr, lsdevinfo, et al -- no rtas_ibm_get_vpd)

[nathanlynch]

also it's an easy revert if someone actually depends on it?

[tyreld]

ok, after looking closer at lsvpd its clear that tool at some point just absorbed this code. I think I feel better about removing it now.