-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The --keepdb flag is not respected for test databases #104
Comments
Somewhat related issue is that Django allows you to provide the name of the test database: But python-ibmdb-django always uses this format instead: For reference this is what BaseDatabaseCreation does in django: If you'd rather this be a separate issue let me know and I'll do that instead. |
@boc-tdunn usually customers wont keep test database hence we ignored this option. We will handle this in coming releases. |
I can't promise anything but would this be an issue you would accept a contribution for? |
I didnt understand. |
Would I be allowed to submit a Pull Request for this issue? |
yes sure, we appreciate everybody's contribution. But we merge it when we plan for next release. |
@boc-tdunn We do not see any PR from you yet. Better to open soon and close this issue. Thanks. |
The django docs state that the --keepdb flag should keep the test database from being destroyed after a test run, and that subsequent test runs should not recreate the test database if it exists already.
https://docs.djangoproject.com/en/5.1/topics/testing/overview/#the-test-database
For reference the POSTGRES django adapter does this.
https://github.com/django/django/blob/main/django/db/backends/postgresql/creation.py#L42-L45
The text was updated successfully, but these errors were encountered: