Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message if fmu path not existant #475

Closed
EttoreZ opened this issue Aug 18, 2022 · 4 comments
Closed

Error message if fmu path not existant #475

EttoreZ opened this issue Aug 18, 2022 · 4 comments
Milestone

Comments

@EttoreZ
Copy link
Contributor

EttoreZ commented Aug 18, 2022

This issue is to check that fmupath in testcase.py TestCase __Init__ method exists or else an exception is thrown. The proposed modification is to add a try: execpt: with the os.path.exists() method.

@dhblum
Copy link
Collaborator

dhblum commented Aug 18, 2022

Sounds great. Want to make a PR to https://github.com/ibpsa/project1-boptest/tree/issue475_fmuPath?

@dhblum dhblum added this to the v1.0.0 milestone Aug 18, 2022
@EttoreZ
Copy link
Contributor Author

EttoreZ commented Aug 18, 2022

Thank you for creating the branch @dhblum . I will make a PR on that branch tomorrow morning

@EttoreZ
Copy link
Contributor Author

EttoreZ commented Aug 22, 2022

@dhblum I updated the pull request. Also to leave trace here for our conversation today. In a future version the error trigger should be moved directly to the bash script to be more precise in the error identification.

@dhblum
Copy link
Collaborator

dhblum commented Aug 25, 2022

Closed by #478.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants