Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can icat-ansible run the schema upgrade scripts? #4

Closed
stuartpullinger opened this issue Jan 30, 2019 · 1 comment · Fixed by icatproject/icat.server#217
Closed
Assignees

Comments

@stuartpullinger
Copy link
Contributor

As noted in icatproject/icat.server#207, the travis build fails because the schema upgrade script is not run. Is there a way to build a string from the version number and look for the matching sql file and run it if it exists?

@RKrahl
Copy link

RKrahl commented Jan 30, 2019

This might be somewhat difficult. First of all it would need to automatically detect, if a schema upgrade is needed and which upgrade script is the proper one to run. Then, reading the install instructions, you will see that not all the upgrades have been straightforward in the past. Also the naming of the upgrade scripts has not always been consistent.

A simpler approach has been sketched in my comment in icatproject/icat.server#205: If the icat.server integration tests would use setup install to deploy, one would only need to make sure either not to install an old version at all or to wipe the icat database before running the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants