Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select field doesn't work with id = 0 #234

Closed
Aareksio opened this issue Jun 19, 2017 · 4 comments
Closed

Select field doesn't work with id = 0 #234

Aareksio opened this issue Jun 19, 2017 · 4 comments

Comments

@Aareksio
Copy link

You can't set id: 0 in select type field values.

{
  label: 'WCF Binding',
  type: 'select',
  model: 'WCFBinding',
  values: [
    { id: 0, name: 'NetTcp' },
    { id: 1, name: 'BasicHttp' },
    { id: 2, name: 'WSHttp' }
  ],
  default: 0,
}

The check here fails when item.id = 0 and instead of id property alone, returns the whole object, so we end up with [Object object] in value HTML field...

It was already mentioned in #186, without reaction, so perhaps it's intended. If that's the case, please provide information on how to achieve the expected result (value = 0).

@icebob
Copy link
Member

icebob commented Jun 30, 2017

Please make a fiddle with the issue.

@Aareksio
Copy link
Author

Aareksio commented Jul 1, 2017

@icebob icebob closed this as completed in 42b4fcb Jul 1, 2017
@icebob
Copy link
Member

icebob commented Jul 1, 2017

Thanks. Fixed

@icebob
Copy link
Member

icebob commented Oct 20, 2017

Released in v2.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants