New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up the units #13

Open

apizzuto opened this issue Feb 3, 2021 · 1 comment

Labels

apizzuto commented Feb 3, 2021

"erg/year? Yuck! this includes providing more clear units for the case of transient simulation."

itaboada added the Required for JOSS publication label

Contributor

renereimann commented Feb 25, 2021

Using erg/year or erg/s is the standard in astrophysics community. You can see that the Waxman and Murase paper (https://arxiv.org/abs/1607.01601) or Mertsch et al (http://arxiv.org/abs/1612.07311) all use these units.

itaboada added enhancement and removed Required for JOSS publication labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment