Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert the change to make IMultiplexedStream disposable #2381

Closed
bentoi opened this issue Dec 23, 2022 · 0 comments
Closed

Revert the change to make IMultiplexedStream disposable #2381

bentoi opened this issue Dec 23, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@bentoi
Copy link
Contributor

bentoi commented Dec 23, 2022

The intent of making IMultiplexedStream disposable was to await on SlicStream tasks and to dispose the Quic stream when the reading and writing sides were completed.

For Slic: awaiting the sending of the stream reset/stop sending/unidirecitonal stream release frame is not needed since these tasks don't throw exceptions other than unexpected exceptions.

For Quic: it doesn't work because ReadsClosed completes to soon and because aborting the stream from the writes closed continuation sporadically cause the peer reading side to complete successfully, see;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant