-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
icepyx required variables #467
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
This is a write up about the presence of required variables in IS2 products. We find that all supported products except ATL14, ATL15, and ATL23 have the required variables. This difference can be ignored when ordering granules, but needs to be accounted for when reading.
Presence of Required Variables
The complete list of variables required by icepyx is:
After inspecting the data products which icepyx supports (list from is2ref._validate_product) we find that most of the products have all these variables.
We see that ATL14, ATL15, and ATL23 are the products which do not have any of these variables. ATL11 is missing two, but this is already accounted for in the icepyx code base.
Accounting for this difference in the code base
It seems that when ordering granules extraneous variables are ignored. This can be see with the following code, which runs without error:
Trying to read the downloaded file, however, results in a ValueError:
I suggest, then, that in PR #451 we:
load
method. Since the list of products (14, 15, 23) is not the same as the products inbuild_single_file_dataset
I don't see a reason to combine the logic.Update: This was quite simple, so it has been pushed to the current version of the PR. We can of course change it!
The text was updated successfully, but these errors were encountered: