Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong latest reported for stripe-go (skipped version problem?) #37

Closed
KenjiTakahashi opened this issue Oct 10, 2024 · 4 comments
Closed

Comments

@KenjiTakahashi
Copy link

The latest version reported for https://pkg.go.dev/github.com/stripe/stripe-go is v76. The actual latest is v80 (at the time of writing).
Might be worth noting that v77 doesn't exist. This might be tripping the tool.

@icholy
Copy link
Owner

icholy commented Oct 10, 2024

Yeah, unfortunately that's a limitation of the tool. It's currently noted here: https://github.com/icholy/gomajor?tab=readme-ov-file#warning

The latest version will not be found if there are gaps between major version numbers.

The module proxy doesn't provide a way to query all major versions of a module, so this tool is forced to incrementally check the existence of each version.

@icholy
Copy link
Owner

icholy commented Oct 10, 2024

See the 5 comments starting here: golang/go#40323 (comment)

@KenjiTakahashi
Copy link
Author

Ach, I somehow missed that warning line, sorry! I even participated in that issue myself, albeit later on than this :-).
I guess feel free to close this, then, as it's not actionable ATM.

@icholy
Copy link
Owner

icholy commented Oct 10, 2024

FWIW, it looks like we're finally going to get built-in support for listing new major versions: golang/go#67420

@icholy icholy closed this as completed Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants