armflang build errors

[ashterenli]

Trying to build papi with armflang, I get to:

make[1]: Entering directory `/home/ec2-user/tmp/1698778753/papi/src/components/sysdetect/tests'
armclang -DUSE_PTHREAD_MUTEXES  -DPAPI_NUM_COMP=3 -O2 -I. -I../../.. -I../../../testlib -I../../../validation_tests -I/bm/ashterenli/install/u_arm/23.10/papi-ea3cc0041/include -c -o query_device_simple.o query_device_simple.c
armclang -DUSE_PTHREAD_MUTEXES  -DPAPI_NUM_COMP=3 -I. -I../../.. -I../../../testlib -I../../../validation_tests -I/bm/ashterenli/install/u_arm/23.10/papi-ea3cc0041/include -o query_device_simple query_device_simple.o ../../../testlib/libtestlib.a ../../../libpapi.a -ldl
armflang  -I../../.. -o query_device_simple_f query_device_simple_f.F ../../../libpapi.a -ldl
F90-S-0021-Label field of continuation line is not blank (../../../f90papi.h: 14)
F90-S-0021-Label field of continuation line is not blank (../../../f90papi.h: 15)
F90-S-0021-Label field of continuation line is not blank (../../../f90papi.h: 16)
F90-S-0021-Label field of continuation line is not blank (../../../f90papi.h: 17)
F90-S-0021-Label field of continuation line is not blank (../../../f90papi.h: 18)
F90-S-0021-Label field of continuation line is not blank (../../../f90papi.h: 19)
F90-S-0021-Label field of continuation line is not blank (../../../f90papi.h: 20)
F90-S-0021-Label field of continuation line is not blank (../../../f90papi.h: 21)
F90-S-0021-Label field of continuation line is not blank (../../../f90papi.h: 22)
F90-S-0021-Label field of continuation line is not blank (../../../f90papi.h: 23)
F90-S-0021-Label field of continuation line is not blank (../../../f90papi.h: 24)
F90-S-0021-Label field of continuation line is not blank (../../../f90papi.h: 25)
F90-S-0021-Label field of continuation line is not blank (../../../f90papi.h: 26)
F90-S-0021-Label field of continuation line is not blank (../../../f90papi.h: 27)
F90-S-0021-Label field of continuation line is not blank (../../../f90papi.h: 28)
F90-S-0021-Label field of continuation line is not blank (../../../f90papi.h: 29)
F90-S-0021-Label field of continuation line is not blank (../../../f90papi.h: 30)
F90-S-0021-Label field of continuation line is not blank (../../../f90papi.h: 31)
F90-S-0021-Label field of continuation line is not blank (../../../f90papi.h: 32)
F90-S-0021-Label field of continuation line is not blank (../../../f90papi.h: 33)
F90-S-0021-Label field of continuation line is not blank (../../../f90papi.h: 34)
F90-S-0021-Label field of continuation line is not blank (../../../f90papi.h: 35)
F90-S-0021-Label field of continuation line is not blank (../../../f90papi.h: 36)
F90-S-0021-Label field of continuation line is not blank (../../../f90papi.h: 37)
F90-S-0021-Label field of continuation line is not blank (../../../f90papi.h: 38)
F90-F-0008-Error limit exceeded (../../../f90papi.h: 3)
F90/aarch64 Linux FlangArm F90  - 1.5 2017-05-01: compilation aborted
make[1]: *** [query_device_simple_f] Error 1
make[1]: Leaving directory `/home/ec2-user/tmp/1698778753/papi/src/components/sysdetect/tests'

Seems components/sysdetect/tests/Makefile needs to be updated.

In contrast, the flags seem correct in ftests:

make[1]: Entering directory `/home/ec2-user/tmp/1698778753/papi/src/ftests'
armflang -I../testlib -I. -I.. -DUSE_PTHREAD_MUTEXES  -DPAPI_NUM_COMP=3 -ffixed-line-length-132 -O1 strtest.F ../testlib/libtestlib.a ../libpapi.a -ldl -o strtest

[ashterenli]

Forgot to say that I'm using this recent commit:

ea3cc00

[gcongiu]

@ashterenli can you check if the patch works for you?

[ashterenli]

@gcongiu you mean this patch?

https://github.com/icl-utk-edu/papi/pull/108/files

[ashterenli]

that is a wrong flag. Instead -ffree-form should be used:

https://developer.arm.com/documentation/101380/2304/Compiler-options/-ffree-form?lang=en

This is my fix:

sed -i '23i FFLAGS += -ffree-form' components/sysdetect/tests/Makefile

[gcongiu]

@ashterenli I updated the PR to reflect your fix.