Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default Icon Color #162

Closed
wei opened this issue Nov 10, 2022 · 3 comments · Fixed by #165
Closed

Default Icon Color #162

wei opened this issue Nov 10, 2022 · 3 comments · Fixed by #165
Assignees
@wootsbot

Comments

@wei
Copy link
Contributor

wei commented Nov 10, 2022

Simple Icons exposes hex which is the default color of any icon.

This color is currently not exposed to the users of this package and there is no way to retrieve it.

I would like to propose supporting something like <ReactJs color size={24} /> which will fill the svg with the default hex color.
@wei wei changed the title Default Icon Hex Color Default Icon Color Nov 10, 2022
@wootsbot
Copy link
Member

I think we can take the colors from the simple-icons JSON, I think it's a good idea, like @LitoMore

@wootsbot wootsbot self-assigned this Nov 10, 2022
@wei
Copy link
Contributor Author

wei commented Nov 10, 2022

Awesome should be an easy change after #161 is merged.

@wootsbot
Copy link
Member

@wei no problem we can send it in a version very soon.

@wei wei mentioned this issue Nov 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wootsbot wootsbot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add default color support wei/react-simple-icons
2 participants
@wei @wootsbot