Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VB namespace global.xxx => C# namespace xxx (global not supported) #67

Closed
BaronBodissey opened this issue Mar 23, 2018 · 4 comments
Closed
Assignees

Comments

@BaronBodissey
Copy link

BaronBodissey commented Mar 23, 2018

[Fact]
public void TestGlobalNamespace()
{
TestConversionVisualBasicToCSharp(@"Namespace Global.Test
End Namespace", @"using System;
using System.Collections.Generic;
using System.Linq;
using Microsoft.VisualBasic;

namespace Test
{
}");

@BaronBodissey
Copy link
Author

BaronBodissey commented Mar 23, 2018

I added the fact directly in here as you removed it from the code...I don't understand why!

@GrahamTheCoder
Copy link
Member

GrahamTheCoder commented Mar 23, 2018

Apologies! It seemed unrelated to the widening/narrowing and I thought it was some unfinished work you'd accidentally added! I'll take a look soon and add it back. Thanks for adding info to #46 !

@BaronBodissey
Copy link
Author

Ok.
Also, I do have an issue with a fact already written but deactivated:
[Fact(Skip = "Not implemented!")]
public void TestIndexer()

Should I open another issue specifically for the indexer/default property?

@GrahamTheCoder
Copy link
Member

Yes please for the indexer - I've pulled the default property out of "known limitations" and into issue #68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants