-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Serializable attribute to ZipException #365
Comments
I think this was skipped due to .NET Standard 1 not supporting it. But since we are now targeting .NET Standard 2, inclusion should no longer be an issue. A PR would be welcomed! |
Thanks for reply, Is there a ETA for the support ? |
No, there is currently no ongoing effort to support this. |
There are several exception types defined in the library - if this was going to be done, would it be worth looking over all of them rather than just ZipException? |
Yeah, but it should just be a matter of adding |
Ok (wasn't sure if they'd need the SerializationInfo constructor overloads adding as well.) |
@fatimagullmadni Do the changes in the 1.2.0 release work for your use case? |
Steps to reproduce
Expected behavior
the exception is serializable so it does not clash with WCF
Actual behavior
exception=System.Runtime.Serialization.SerializationException: Type 'ICSharpCode.SharpZipLib.Zip.ZipException' in Assembly 'ICSharpCode.SharpZipLib, Version=1.1.0.145, Culture=neutral, PublicKeyToken=1b03e6acf1164f73' is not marked as serializable.
Version of SharpZipLib
1.1.0.145
Obtained from (only keep the relevant lines)
The text was updated successfully, but these errors were encountered: