Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Serializable attribute to ZipException #365

Closed
fatimagullmadni opened this issue Jul 4, 2019 · 7 comments
Closed

Add Serializable attribute to ZipException #365

fatimagullmadni opened this issue Jul 4, 2019 · 7 comments
Labels
enhancement Feature request or other improvements of existing functionality help wanted

Comments

@fatimagullmadni
Copy link

Steps to reproduce

  1. Use WCF service
  2. Call some Zip functionality where exception is triggered

Expected behavior

the exception is serializable so it does not clash with WCF

Actual behavior

exception=System.Runtime.Serialization.SerializationException: Type 'ICSharpCode.SharpZipLib.Zip.ZipException' in Assembly 'ICSharpCode.SharpZipLib, Version=1.1.0.145, Culture=neutral, PublicKeyToken=1b03e6acf1164f73' is not marked as serializable.

Version of SharpZipLib

1.1.0.145

Obtained from (only keep the relevant lines)

  • Package installed using NuGet
@piksel
Copy link
Member

piksel commented Jul 4, 2019

I think this was skipped due to .NET Standard 1 not supporting it. But since we are now targeting .NET Standard 2, inclusion should no longer be an issue. A PR would be welcomed!

@fatimagullmadni
Copy link
Author

Thanks for reply, Is there a ETA for the support ?

@piksel
Copy link
Member

piksel commented Jul 5, 2019

No, there is currently no ongoing effort to support this.

@piksel piksel added enhancement Feature request or other improvements of existing functionality help wanted labels Jul 5, 2019
@piksel piksel changed the title Zip exception is not serializable Add Serializable attribute to ZipException Jul 5, 2019
@Numpsy
Copy link
Contributor

Numpsy commented Aug 1, 2019

There are several exception types defined in the library - if this was going to be done, would it be worth looking over all of them rather than just ZipException?

@piksel
Copy link
Member

piksel commented Aug 1, 2019

Yeah, but it should just be a matter of adding [Serializable] in the declaration.

@Numpsy
Copy link
Contributor

Numpsy commented Aug 1, 2019

Ok (wasn't sure if they'd need the SerializationInfo constructor overloads adding as well.)

@Numpsy
Copy link
Contributor

Numpsy commented Aug 15, 2019

@fatimagullmadni Do the changes in the 1.2.0 release work for your use case?

@piksel piksel closed this as completed Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request or other improvements of existing functionality help wanted
Projects
None yet
Development

No branches or pull requests

3 participants