Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET Standard 1.x support #368

Closed
NightOwl888 opened this issue Jul 30, 2019 · 5 comments
Closed

.NET Standard 1.x support #368

NightOwl888 opened this issue Jul 30, 2019 · 5 comments

Comments

@NightOwl888
Copy link

I read #206 already, and it seems you could support .NET Standard 1.3 with no changes. Why did you only add support for .NET Standard 2.0?

We depend on this library and support .NET Standard 1.6, but had to go with an "unofficial" copy SharpZipLib.NetStandard. However, that library is not strong named and we have recently added strong naming. So, now we are stuck either releasing yet another clone, or getting you to support .NET Standard 1.x.

@piksel
Copy link
Member

piksel commented Aug 6, 2019

I think you mean #106? The reason for 2.x had to do with the new Streams API that we rely on (see System.IO.Stream.Close())

Why are you supporting 1.6? There are hardly any benefits support-wise. For older frameworks we support net45 which also contains the updated Streams API.

@NightOwl888
Copy link
Author

We are supporting 1.6 primarily for .NET Core 1.x support. We already target net45 and netstandard2.0, but neither of them support it.

Okay, so maybe you can't port the latest version to .NET Standard 1.x, what about doing an update to an older version to support it? We don't need the latest features, we just need a way to support bzip2 and the version that we started with, 0.86.0 works fine for our purposes.

BTW - the top 2 projects on NuGet are NUnit and NewtonSoft.Json and both of them support .NET Standard 1.x, along with most of the other projects on the first page.

@piksel
Copy link
Member

piksel commented Aug 6, 2019

I see, we have no plans to add support for 1.x unfortunately.
And re-releasing an older version for netstandard1.6 would add even more support overhead. We have intentionally limited the scope to ns2 and net45.

@Numpsy
Copy link
Contributor

Numpsy commented Aug 6, 2019

I suppose an older target would also conflict with #369, unless the extra bits were conditionally included.

@piksel piksel added the wontfix label Aug 4, 2020
@piksel piksel closed this as completed Aug 4, 2020
@NightOwl888
Copy link
Author

Thanks for closing this. Actually, we have already dropped support for .NET Standard 1.x because it became too difficult to support. So this problem has resolved itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants