Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix test in raven master branch #1031

Closed
10 tasks done
wangcj05 opened this issue Aug 7, 2019 · 2 comments · Fixed by #1032
Closed
10 tasks done

fix test in raven master branch #1031

wangcj05 opened this issue Aug 7, 2019 · 2 comments · Fixed by #1032

Comments

@wangcj05
Copy link
Collaborator

wangcj05 commented Aug 7, 2019


Issue Description

What did you expect to see happen?

Master branch tests should pass

What did you see instead?

currently failed

Do you have a suggested fix for the development team?
Please attach the input file(s) that generate this error. The simpler the input, the faster we can find the issue.

For Change Control Board: Issue Review

This review should occur before any development is performed as a response to this issue.

  • 1. Is it tagged with a type: defect or task?
  • 2. Is it tagged with a priority: critical, normal or minor?
  • 3. If it will impact requirements or requirements tests, is it tagged with requirements?
  • 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
  • 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure

This review should occur when the issue is imminently going to be closed.

  • 1. If the issue is a defect, is the defect fixed?
  • 2. If the issue is a defect, is the defect tested for in the regression test system? (If not explain why not.)
  • 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
  • 4. If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
  • 5. If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?
@wangcj05
Copy link
Collaborator Author

wangcj05 commented Aug 7, 2019

one test crashed

@PaulTalbot-INL
Copy link
Collaborator

The defects in question cannot cause incorrect results for users; it is modification of a testing-based external model. No notifications are needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants