Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEFECT] VarGroups can't be used in the "inner" outstream dataobjects #1822

Closed
13 tasks done
PaulTalbot-INL opened this issue Apr 28, 2022 · 1 comment · Fixed by #1823
Closed
13 tasks done

[DEFECT] VarGroups can't be used in the "inner" outstream dataobjects #1822

PaulTalbot-INL opened this issue Apr 28, 2022 · 1 comment · Fixed by #1823

Comments

@PaulTalbot-INL
Copy link
Collaborator

PaulTalbot-INL commented Apr 28, 2022

Thank you for the defect report

Defect Description

If a variable group is used in the "inner" RrR run, within the dataobject which is returned as the output of the inner run, then the RavenInterface as implemented won't respect that, and will claim the variable group is a variable that is missing.

Steps to Reproduce

  1. Add a variable group to a RrR inner dataobject that is returned as a solution
  2. Make some popcorn
  3. See the variable group is treated as a variable rather than replaced by the RavenInterface

Expected Behavior

Not erroring when using the feature described above

Screenshots and Input Files

No response

OS

MacOS

OS Version

No response

Dependency Manager

CONDA

For Change Control Board: Issue Review

  • Is it tagged with a type: defect or task?
  • Is it tagged with a priority: critical, normal or minor?
  • If it will impact requirements or requirements tests, is it tagged with requirements?
  • If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
  • Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure

  • If the issue is a defect, is the defect fixed?
  • If the issue is a defect, is the defect tested for in the regression test system? (If not explain why not.)
  • If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
  • If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
  • If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?
@joshua-cogliati-inl
Copy link
Contributor

This would have caused an error before, so no email needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants