Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The connected net check in the ensemble model can return false even if the model are connected #696

Closed
10 tasks done
wangcj05 opened this issue Jul 19, 2018 · 4 comments · Fixed by #732
Closed
10 tasks done

Comments

@wangcj05
Copy link
Collaborator

wangcj05 commented Jul 19, 2018


Issue Description

What did you expect to see happen?

The models are connected in the Ensemble model, the isConnectedNet() should return True

What did you see instead?

The isConnectedNet() return False for the following connected model

a->b->c
   ^
   |
e->d->f

and

a->|
b->| ->d 
c->|
Do you have a suggested fix for the development team?
Please attach the input file(s) that generate this error. The simpler the input, the faster we can find the issue.

For Change Control Board: Issue Review

This review should occur before any development is performed as a response to this issue.

  • 1. Is it tagged with a type: defect or improvement?
  • 2. Is it tagged with a priority: critical, normal or minor?
  • 3. If it will impact requirements or requirements tests, is it tagged with requirements?
  • 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
  • 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure

This review should occur when the issue is imminently going to be closed.

  • 1. If the issue is a defect, is the defect fixed?
  • 2. If the issue is a defect, is the defect tested for in the regression test system? (If not explain why not.)
  • 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
  • 4. If the issue is a defect, does it impact the latest stable branch? If yes, is there any issue tagged with stable (create if needed)?
  • 5. If the issue is being closed without a merge request, has an explanation of why it is being closed been provided?
@wangcj05
Copy link
Collaborator Author

@mandd @alfoa I have opened this issue for the Ensemble Model connect net check.

@alfoa
Copy link
Collaborator

alfoa commented Jul 20, 2018

PR #698 was supposed to close this.

Closure checklist passed.

Closing...

@alfoa alfoa closed this as completed Jul 20, 2018
@wangcj05 wangcj05 reopened this Jul 23, 2018
@wangcj05
Copy link
Collaborator Author

PR#698 is only merged to mandd/CRAFT branch, not devel. This issue will be finally closed when branch mandd/CRAFT is merged to devel. @alfoa

@alfoa
Copy link
Collaborator

alfoa commented Aug 9, 2018

Closure list passed...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants