SPD fix #578
Merged
SPD fix #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SPD have appended extra characters to a small number of postcodes - causing those postcodes to be unqueryable
Some postcodes on SPD have an extra character appended. Since these are picked up as invalid postcodes, they can no longer be queried This change will ingest the first instance of these invalid postcodes (i.e. those ending with A) and drop all others
Codecov Report
@@ Coverage Diff @@
## master #578 +/- ##
==========================================
+ Coverage 98.01% 98.03% +0.01%
==========================================
Files 40 40
Lines 1312 1320 +8
==========================================
+ Hits 1286 1294 +8
Misses 26 26
Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 12.0.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
cblanc
added a commit
that referenced
this pull request
Dec 17, 2020
Reintroduces fix from #578 Some postcodes on SPD have an extra character appended. Since these are picked up as invalid postcodes, they can no longer be queried This change will ingest the first instance of these invalid postcodes (i.e. those ending with A) and drop all others
cblanc
added a commit
that referenced
this pull request
Dec 17, 2020
Reintroduces fix from #578 Some postcodes on SPD have an extra character appended. Since these are picked up as invalid postcodes, they can no longer be queried This change will ingest the first instance of these invalid postcodes (i.e. those ending with A) and drop all others
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some postcodes on SPD have an extra character appended. Since these are
picked up as invalid postcodes, they can no longer be queried
This change will ingest the first instance of these invalid postcodes
(i.e. those ending with A) and drop all others
Fixes #577