Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] PROM2TEAMS_PROMETHEUS_METRICS #325

Closed
ebini opened this issue Dec 14, 2022 · 3 comments
Closed

[BUG] PROM2TEAMS_PROMETHEUS_METRICS #325

ebini opened this issue Dec 14, 2022 · 3 comments
Labels
bug wontfix

Comments

@ebini
Copy link

ebini commented Dec 14, 2022

Description

setting the Environment Variable PROM2TEAMS_PROMETHEUS_METRICS=true (like in the README.md
is not working (anymore)

Steps to Reproduce

set PROM2TEAMS_PROMETHEUS_METRICS=true
connecting to /metrics returns still 404

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2 Final//EN">
<title>404 Not Found</title>
<h1>Not Found</h1>
<p>The requested URL was not found on the server. If you entered the URL manually please check your spelling and try again.</p>

Expected behavior:
metrics data

Actual behavior:
404

Reproduces how often:
always

Environment

deployed in k8s cluster
verified setting by "shelling" into the container

/opt/prom2teams $ printenv | grep PROM2TEAMS_PROMETHEUS_METRICS
PROM2TEAMS_PROMETHEUS_METRICS=true

Additional Information

worked in older versions (but this was long time ago)
@ebini ebini added the bug label Dec 14, 2022
@santi-eidu
Copy link
Contributor

Metrics are in port 9090, are you checking this port? I cannot reproduce the error.

@mateuszdrab
Copy link

mateuszdrab commented Jan 19, 2023 •
edited
Loading

Is there a way to revert to the old behavior?
The helm chart does not have a port for metrics and I'm running with Rancher's fork of prom2teams included in rancher-alerting-drivers so even if resolved here, it will take long time to get pulled into their repo. I already had to manually add the ServiceMonitor resource and switch to using their dev branch.

prom2teams/prom2teams/app/configuration.py

Line 133 in 340d47d

if application.config['ENV'] == "werkzeug":

I think setting the ENV config parameter would revert the old behavior, but I'm not sure how to achieve that.

I rolled back to version 4.0.0 for now

santi-eidu pushed a commit that referenced this issue Jan 23, 2023
#325 fix metrics port in helm
d482842
santi-eidu pushed a commit that referenced this issue Jan 23, 2023
#325 fix in monitor port deployment
97d8394
@santi-eidu santi-eidu mentioned this issue Jan 23, 2023
Merged
santi-eidu pushed a commit that referenced this issue Jan 27, 2023
#325 Update CHANGELOG.md
3b761fc
@stale
Copy link

stale bot commented Mar 25, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Mar 25, 2023
@stale stale bot closed this as completed Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug wontfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ebini @mateuszdrab @santi-eidu