Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Presets should enumerate expected roles #134

Open
1ec5 opened this issue Feb 12, 2024 · 0 comments · May be fixed by #174
Open

Presets should enumerate expected roles #134

1ec5 opened this issue Feb 12, 2024 · 0 comments · May be fixed by #174
Labels
enhancement New feature or request

Comments

@1ec5
Copy link
Contributor

1ec5 commented Feb 12, 2024

A preset that applies to relations should be able to list the expected member roles, along with a translatable label and expected element types for each role.

Currently, id-tagging-schema has no data on roles, so iD’s relation member editor simply lists the most common roles in taginfo for a given relation type: openstreetmap/iD#3300. id-tagging-schema’s multipolygon preset could specify Inner Ring (inner) and Outer Ring (outer) roles, disallowing other roles which would be invalid: openstreetmap/iD#8268.

Some roles are counterintuitive; a translatable string would give us the opportunity to make them less misleading. For example, the English label for admin_centre could be “Capital”, so that mappers don’t incorrectly assign it to a capitol building.

If the preset could say how many members of a relation can have a given role, and what element types are eligible, then the editor can implement a validation role to that effect. For example, iD could warn if a boundary relation has two Focal Point (label) members or a restriction relation has a node as its From (from) member.

@tyrasd tyrasd added the enhancement New feature or request label Feb 14, 2024
@k-yle k-yle linked a pull request Dec 20, 2024 that will close this issue
@k-yle k-yle linked a pull request Feb 22, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants