Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

morgan.ini: "cffi = >=1.15.1" doesn't work, but "cffi = ==1.15.1" does #5

Open
shamilbi opened this issue Nov 24, 2022 · 7 comments
Open

Comments

@shamilbi
Copy link
Collaborator

shamilbi commented Nov 24, 2022

morgan-0.12.3, python-3.10, linux-x86_64
morgan mirror

@shamilbi
Copy link
Collaborator Author

"cffi = >1.15.0" doesn't work too

@ido50
Copy link
Owner

ido50 commented Nov 24, 2022

Can you provide any output? I just tried it and did not encounter any issues.

@shamilbi
Copy link
Collaborator Author

rm -rf cffi
morgan mirror # cffi = >=1.15.1
ls cffi

output:
cffi-1.0.2-2.tar.gz
cffi-1.0.2-2.tar.gz.hash
cffi-1.0.2-2.tar.gz.metadata

@shamilbi
Copy link
Collaborator Author

rm -rf cffi
morgan mirror # cffi = ==1.15.1
ls cffi

output:
cffi-1.15.1-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
cffi-1.15.1-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.hash
cffi-1.15.1-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata
cffi-1.15.1-cp310-cp310-musllinux_1_1_x86_64.whl
cffi-1.15.1-cp310-cp310-musllinux_1_1_x86_64.whl.hash
cffi-1.15.1-cp310-cp310-musllinux_1_1_x86_64.whl.metadata
cffi-1.15.1.tar.gz
cffi-1.15.1.tar.gz.hash
cffi-1.15.1.tar.gz.metadata

@ido50
Copy link
Owner

ido50 commented Nov 24, 2022

Well I can see the issue, there's a "renegade" cffi release called "1.0.2-2", and that "-2" suffix isn't standard as far as Python module versioning goes, so it causes the packaging library to parse the version as "2" instead of "1.0.2", which is bigger than "1.15.1". I'll have to think about this one, this may be an isolated case.

@ido50
Copy link
Owner

ido50 commented Nov 24, 2022

For now you can do cffi = >=1.15.1,<2 as a workaround until I find a proper solution.

@shamilbi
Copy link
Collaborator Author

For now you can do cffi = >=1.15.1,<2 as a workaround until I find a proper solution.

That works thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants