Skip to content

Commit d82b19d

Browse files
Merge pull request #805 from ie3-institute/to/#804-srated-unit-fix
Adjust wrong unit comments
2 parents bb423e8 + 6203d42 commit d82b19d

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1111
- Allow hierarchic grid structure for JointGridContainer [#768](https://github.com/ie3-institute/PowerSystemDataModel/issues/768)
1212

1313
### Fixed
14+
- Fixed wrong rated power unit hint [#804](https://github.com/ie3-institute/PowerSystemDataModel/issues/804)
1415

1516

1617
### Changed

src/main/java/edu/ie3/datamodel/models/input/connector/type/Transformer2WTypeInput.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ public class Transformer2WTypeInput extends AssetTypeInput {
1818
private final ComparableQuantity<ElectricResistance> rSc;
1919
/** Short circuit reactance (typically in Ohm) */
2020
private final ComparableQuantity<ElectricResistance> xSc;
21-
/** Rated apparent power (typically in MVA) */
21+
/** Rated apparent power (typically in kVA) */
2222
private final ComparableQuantity<Power> sRated;
2323
/** Rated voltage of the high voltage winding (typically in kV) */
2424
private final ComparableQuantity<ElectricPotential> vRatedA;
@@ -46,7 +46,7 @@ public class Transformer2WTypeInput extends AssetTypeInput {
4646
* @param id of the type
4747
* @param rSc Short circuit resistance
4848
* @param xSc Short circuit reactance
49-
* @param sRated Rated apparent power (typically in MVA)
49+
* @param sRated Rated apparent power (typically in kVA)
5050
* @param vRatedA Rated voltage of the high voltage winding
5151
* @param vRatedB Rated voltage of the low voltage winding
5252
* @param gM Phase-to-ground conductance

src/main/java/edu/ie3/datamodel/models/input/connector/type/Transformer3WTypeInput.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,11 @@
1414

1515
/** Describes the type of a {@link edu.ie3.datamodel.models.input.connector.Transformer3WInput} */
1616
public class Transformer3WTypeInput extends AssetTypeInput {
17-
/** Rated apparent power of the high voltage winding (typically in MVA) */
17+
/** Rated apparent power of the high voltage winding (typically in kVA) */
1818
private final ComparableQuantity<Power> sRatedA; // Hv
19-
/** Rated apparent power of the medium voltage winding (typically in MVA) */
19+
/** Rated apparent power of the medium voltage winding (typically in kVA) */
2020
private final ComparableQuantity<Power> sRatedB; // Mv
21-
/** Rated apparent power of the low voltage windings (typically in MVA) */
21+
/** Rated apparent power of the low voltage windings (typically in kVA) */
2222
private final ComparableQuantity<Power> sRatedC; // Lv
2323
/** Rated voltage magnitude of the high voltage winding (typically in kV) */
2424
private final ComparableQuantity<ElectricPotential> vRatedA; // Hv

0 commit comments

Comments
 (0)