Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve weighting of weather from different coordinates #173

Closed
ckittl opened this issue Mar 14, 2022 · 0 comments · Fixed by #79
Closed

Improve weighting of weather from different coordinates #173

ckittl opened this issue Mar 14, 2022 · 0 comments · Fixed by #79
Assignees
@ckittl
Labels
bug Something isn't working
Milestone
Version 3.0

Comments

@ckittl
Copy link
Member

ckittl commented Mar 14, 2022

With current implementation of WeatherSourceWrapper, there might be a corner case, that is not properly reflected, yet:

If for all coordinates a given weather attribute is unavailable (e.g. there is no temperature information in all coordinates), the weight sum for this attribute equals zero. Thus, when determining the weighted average of this attribute, a division by zero would happen.
@ckittl ckittl added the bug Something isn't working label Mar 14, 2022
@ckittl ckittl added this to the Version 3.0 milestone Mar 14, 2022
@ckittl ckittl self-assigned this Mar 14, 2022
@ckittl ckittl mentioned this issue Mar 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ckittl ckittl

Labels
bug Something isn't working
Projects
None yet
Milestone
Version 3.0
Development

Successfully merging a pull request may close this issue.

Adapt default resolution of weather source ie3-institute/simona
1 participant
@ckittl