Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Filter by Number of Stars' Button is not working as expected #68

Open
abdul-haseeb-HSB opened this issue Jun 13, 2024 · 5 comments
Open

Comments

@abdul-haseeb-HSB
Copy link

'Filter by Number of Stars' Button is not working as expected

Expected Behavior:

Should be displaying repos as per the user's entered number

Current Behavior:

BUG

  • Displaying Random Repos regardless of the repo
  • If all fields are selected, entering number of stars doesn't make any difference
  • How to Regenerate -> Video Demo

Enhancements

  • No form validation
  • User should only be allowed to enter the numeric value, currently it is accepting and processing all type of values.
  • This can lead to SQL Injection attack as well
  • How to Regenerate -> Video Demo
@KeithBrosch
Copy link
Contributor

KeithBrosch commented Jun 19, 2024

The field is intended to represent a Minimum Number, not an exact match.

I've changed the wording on the Input Label to make it less confusing, and I've also given the input field type="number" to only allow numeric values.

#69

@shivansh84ya
Copy link

Hey @abdul-haseeb-HSB ,
Could you please assign this issue to me??

@MonsieurRadiant
Copy link

Hey, I have a pr that fixs this issue by adding a maximal value to the repo star filter session
pull request #70

@abhedanil
Copy link

Hi , could you please assign it to me , so that i can work on this issue

@Ravi0529
Copy link

Hi @abdul-haseeb-HSB
What if we'll change totally,

  1. We can set ranges of the Number of stars
  2. User selects the particular range section and will get the repos accordingly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants