Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Improvement: Better handling of no results when filters are applied. #74

Open
NehalSurti opened this issue Sep 3, 2024 · 3 comments

Comments

@NehalSurti
Copy link

UI Improvement: Better handling of no results when filters are applied

Description:

When applying filters that result in no available repositories, the current UI does not effectively communicate this to the user. The page appears empty without any indication that no results match the applied filters.

Additionally, when no results are found:

  • The page numbering, typically located at the bottom of the page, is also repositioned.
  • The "Privacy and cookie settings" element, typically located at the bottom of the page, is also repositioned.

Steps to Reproduce:

  1. Go to the Good First Issues website.
  2. Apply a combination of filters that result in no repositories being found.
  3. Observe the UI when no results are available, noting the position of the page numbering arrows and the "Privacy and cookie settings" element.

Suggested Expected Behavior:

  • A message should be displayed indicating that no repositories match the applied filters.
  • The page numbering arrows should remain in their original position.
  • The "Privacy and cookie settings" element should stay at the bottom of the page.

Actual Behavior:

  • The page is empty with no clear indication that the filters have resulted in no available repositories.
  • The page numbering arrows are displaced from its original position at the bottom of the page.
  • The "Privacy and cookie settings" element is displaced from its original position at the bottom of the page.

Screenshots:

Image 001

Image 002

@Khushboo2724
Copy link

i will like to contribute to this

@vishalpatil1899
Copy link

/assign

@gnaneshreddyy
Copy link

Hello @NehalSurti,

I have reviewed the bug and am very eager to resolve it. Could you please assign it to me? I am confident I can fix it within two days and ensure the website runs smoothly.

Additionally, I am currently unable to see the "Privacy and Cookie Settings" element, which, as you mentioned, should reposition when no search results apply.

Please find the below attachment.
Screenshot 2024-10-26 131923

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants