Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve testing #67

Closed
iegomez opened this issue May 15, 2020 · 0 comments
Closed

Improve testing #67

iegomez opened this issue May 15, 2020 · 0 comments

Comments

@iegomez
Copy link
Owner

iegomez commented May 15, 2020

The test suite was written long ago while starting to develop this plugin and it hasn't aged well: I knew very little Go by then and there are some basic mistakes I did that are starting to creep into new changes. So testing needs a major refactor and rewrite that include at least these:

  1. Switch from goconvey to simple table driven tests and use something like testify/assert to ease checks.
  2. Don't ask users to have every damn service running just so they can be sure tests are passing. Instead, build some Docker or similar environment where services are installed and ran for tests to be held.
  3. Leverage said environment to add a CI service such as CircleCI, Github actions, etc., that will run the test suite for every PR commit and block merging on failure.
  4. Refactor go-auth.go extracting initialization and other work to its own package so it may be properly tested.
@iegomez iegomez changed the title Add CircleCI tests Improve testing May 24, 2020
@iegomez iegomez mentioned this issue Jul 3, 2020
2 tasks
@iegomez iegomez closed this as completed Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant