UUID support (primary keys with default value and crypto extension)

[eraffel-MDSol]

Why is the PK excluded when setting default values on the columns of the views?

chronomodel/lib/chrono_model/adapter/ddl.rb

Line 33 in b00d08c

next if column.name == pk || default.nil?

[tagliala]

I can't tell

Is there something your application is trying to achieve that it is not possible when using CM?

[eraffel-MDSol]

It's failing to insert into the table, it's saying the PK that is being inserted (NEW.id) is null.

[eraffel-MDSol]

I also don't understand what you meant by "I can't tell", the line I linked to skips adding default values to the PK column in the VIEW.

[tagliala]

It's failing to insert into the table, it's saying the PK that is being inserted (NEW.id) is null.

Can I have a reproducible test case?

I also don't understand what you meant by "I can't tell", the line I linked to skips adding default values to the PK column in the VIEW.

Sorry, not a native English speaker. I can't tell exactly why it is being excluded. My guess is that primary key are often automatically generated and for all our use cases it is fine

[eraffel-MDSol]

You can clone this, populate the database.yml, run db setup, and run the rspec. You'll see the error

[eraffel-MDSol]

https://github.com/eraffel-MDSol/chrono-issue-reproduction
whoops, forgot the link

[eraffel-MDSol]

Looks like there's maybe not support for a uuid PK?

[tagliala]

Looks like there's maybe not support for a uuid PK?

Oh, yes, this could be the reason.

I've recently implemented support for string IDs #156, but we do not use UUIDs

We are interested in supporting UUID, but at the moment this feature is out of scope.

Feel free to take a look and propose a PR with test coverage

[evman182]

I opened #188

Sorry, keep switching between work and personal account

[tagliala]

Thanks, it looks good, I would like to test it a little bit more before merging