Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The 'as_of_time' value for historical objects is inaccurate and may lead to unintended consequences #292

Open
tagliala opened this issue May 5, 2024 · 0 comments
Open

The 'as_of_time' value for historical objects is inaccurate and may lead to unintended consequences #292

tagliala opened this issue May 5, 2024 · 0 comments
Labels
bug CRITICAL Critical issues

Comments

@tagliala
Copy link
Member

tagliala commented May 5, 2024

Same issue as #283, since as_of_time is an alias of valid_to in historical objects, but may have different effects

> country.history.first.validity
  Country::History Load (1.2ms)  SELECT "history"."countries".* FROM "history"."countries" WHERE "history"."countries"."id" = $1 ORDER BY lower(validity) ASC LIMIT $2  [["id", 1], ["LIMIT", 1]]
=> 2024-04-14 07:33:14.750087 UTC...2024-04-14 07:35:30.80794 UTC

country.history.first.as_of_time
  Country::History Load (1.3ms)  SELECT "history"."countries".* FROM "history"."countries" WHERE "history"."countries"."id" = $1 ORDER BY lower(validity) ASC LIMIT $2  [["id", 1], ["LIMIT", 1]]
=> 2024-04-14 07:35:30.80794 UTC

2024-04-14 07:35:30.80794 UTC IS NOT included in the validity range of country
@tagliala tagliala added bug CRITICAL Critical issues labels May 5, 2024
@tagliala tagliala changed the title Historical references are using an as_of_time which is theoretically incorrect Historical references are using an as_of_time value that is theoretically incorrect May 5, 2024
@tagliala tagliala changed the title Historical references are using an as_of_time value that is theoretically incorrect Historical objects are using an as_of_time value that is theoretically incorrect May 5, 2024
@tagliala tagliala changed the title Historical objects are using an as_of_time value that is theoretically incorrect The 'as_of_time' value for historical objects is inaccurate and may lead to unintended consequences May 25, 2024
@tagliala tagliala changed the title The 'as_of_time' value for historical objects is inaccurate and may lead to unintended consequences Inaccurate as_of_time for historical objects impacts transaction records May 25, 2024
@tagliala tagliala changed the title Inaccurate as_of_time for historical objects impacts transaction records Inaccurate as_of_time for historical objects impacts transaction records May 25, 2024
@tagliala tagliala changed the title Inaccurate as_of_time for historical objects impacts transaction records The 'as_of_time' value for historical objects is inaccurate and may lead to unintended consequences May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug CRITICAL Critical issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tagliala