Twitter Widget Doesn't Work Over SSL

[dalezak]

The Twitter widget is broken when used on website with SSL.

[dalezak]

[blocked] The page at [website address] was loaded over HTTPS, but ran insecure content from 'http://platform.twitter.com/widgets.js': this content should also be loaded over HTTPS.

[dalezak]

Looks like the problem is due to hardcoded http://platform.twitter.com/widgets.js path, which should instead use the protocol of the host.

https://github.com/iffyuva/social-buttons/blob/master/lib/social_buttons/view_helpers/tweet.rb#L39

[kristianmandrup]

Please fix whatever needs fixin and make a pull request :)
One option is to add a configuration singleton class to be used by all the social buttons ;)

[dalezak]

Hmm, do you need to increment the version number so the gem will be updated?

[dalezak]

After doing bundle update, I'm still getting social-buttons 0.3.7 which still has http:// rather than https://

Any ideas?

[kristianmandrup]

Just reference the repo directly from your gemfile. Yes, the version needs to be bumped and then pushed to RubyGems as a new release.

[kristianmandrup]

Please also add my Config class to the repo and make a new pull request.

#10 (comment)

I'm at work where I can't really do git commands :(