Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy storybook site to production #1390

Closed
julianguyen opened this issue Mar 4, 2019 · 4 comments
Closed

Deploy storybook site to production #1390

julianguyen opened this issue Mar 4, 2019 · 4 comments

Comments

@julianguyen
Copy link
Member

julianguyen commented Mar 4, 2019

Description

Currently, our storybook site is only accessible through the local development environment i.e. running yarn storybook in the client directory.

We want to deploy it to production as well and have it viewable at https://www.if-me.org/design.

We can do that by exporting Storybook as a static app and pointing the output to the new route.

Ideally, we want to this to happen in the build step in our CircleCI config so that we don't have to commit the output to master.

Do you want to be the assignee to work on this?

🚫 This would be a great issue to work on for folks interested in deploys! I'm happy to help if needed :)

@paschalidi
Copy link
Member

@julianguyen @KatieOfCode please let me know if I could help with anything here.

@julianguyen
Copy link
Member Author

@paschalidi maybe you could help review this PR: #1391 and potentially pair with @KatieOfCode? :D

@paschalidi
Copy link
Member

paschalidi commented Mar 17, 2019

@julianguyen I will have a look tomorrow on the PR. Thanks for letting me know.
Can you maybe give me an idea of what the goal of #1391 is? Sorry but the description is not very clear to me.

@julianguyen
Copy link
Member Author

@paschalidi Yeah the goal of this issue is to deploy a static version of the Storybook site (where we house our React components and CSS best practices) on production (at https://www.if-me.org/design).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants