Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): remove Windows support for iggy-server #1541

Merged
merged 1 commit into from
Feb 16, 2025

Conversation

hubcio
Copy link
Contributor

@hubcio hubcio commented Feb 16, 2025

This commit removes Windows support for the server by
introducing a compile-time error for Windows platforms.
The GitHub Actions workflow has been updated to separate
the build and test processes for Linux and Windows,
ensuring that the server is not built on Windows.

This change is needed due to lack of read_at support on
windows and upcoming thread per core architecture changes.

@hubcio hubcio requested a review from a team as a code owner February 16, 2025 15:20
@hubcio hubcio changed the title chore(ci): remove Windows support for iggy-server chore(ci): remove Windows support for iggy-server Feb 16, 2025
@hubcio hubcio force-pushed the dont-compile-server-on-windows branch from faa49db to efc7a76 Compare February 16, 2025 15:25
This commit removes Windows support for the server by
introducing a compile-time error for Windows platforms.
The GitHub Actions workflow has been updated to separate
the build and test processes for Linux and Windows,
ensuring that the server is not built on Windows.

This change is needed due to lack of `read_at` suuport on
windows and upcoming thread per core architecture changes.
BartoszCiesla
BartoszCiesla previously approved these changes Feb 16, 2025
@hubcio hubcio merged commit 4f6ad69 into master Feb 16, 2025
14 checks passed
@hubcio hubcio deleted the dont-compile-server-on-windows branch February 16, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants