Skip to content

Latest commit

 

History

History
41 lines (25 loc) · 1.3 KB

DEVNOTES.md

File metadata and controls

41 lines (25 loc) · 1.3 KB

Dev notes

Implements osparc-simcore #764

Had to adapt cc due to some differencies wrt to the service we have been integrating so far

  • no source code but instead (Dockerfile repo)
  • ubuntu instead of alpine
  • container prints results to stdout instead of a file

Limitations

  1. version syncs to base image? Our layer has to be minimal!
    • might need a version for the adapter itself (similar to jsonschema)
  2. cannot capture errors from opencor entrypoint.sh. Reported to repo.
  3. metadata should be more explicit -> metadata folder at level 0
  4. schema

Upgrading to new version of hsorby/opencor-python

(.venv)$ bump2version patch
$ make build
$ make test

## if ok ...
$ git commit -a -m "Upgraded hsorby/opencor-python:0.2.2

TODO

  • add travis CI
  • should validate failures, i.e. how service reacts to wrong inputs (e.g. return codes, etc). In this case, the entrypoit does not react well to failures
  • review workflow with @sanderegg