feat: Create-fundraiser now a project specific route #153
Conversation
|
Visit the preview URL for this PR (updated for commit b96211d): https://ignite-new--pr153-feat-create-fundrais-fesicpsu.web.app (expires Thu, 16 Jun 2022 14:09:56 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
|
@Matthews3301 afaik we should filter the selling coins list (i.e. total quantity for sale) by The filtering should be in the form of: The paying coins list on the other hand is just a subset from total supply. Currently we subtract whatever is selected for selling coin so to avoid having equal denom for selling and paying. Is this accurate @fadeev ? |
| @@ -141,9 +146,9 @@ const state = reactive(initialState) | |||
|
|
|||
| // lifecycles | |||
| onMounted(() => { | |||
There was a problem hiding this comment.
This other PR is already tackling this code block. Maybe would be better to wait for that one to be merged as well.
|
@marinhoarthur okay, so "selling coins list" - I'll add projectId filtering in this PR, shall I? |
|
@marinhoarthur yes, it is. Thanks! |
| @@ -254,7 +247,9 @@ const isVoucherPriceGreaterThanZero = computed<boolean>(() => | |||
| ) | |||
| const hasAnyBalance = computed<boolean>( | |||
| () => | |||
| (isFetchedBalances.value && balances.value && balances.value.length > 0) || | |||
| (isFetchedBalances.value && | |||
| filteredBalances.value && | |||
There was a problem hiding this comment.
We can omit this condition
Co-authored-by: Jose Felix <jfelx@outlook.com>
…inbits/ignite-ui into feat/create-fundraiser-route
"Create fundraiser" page now uses a project specific url route. This helps with populating project name in the breadcrumbs.
@marinhoarthur should we filter available denoms in "Price per voucher" by
/${projectId}/?Closes #140