v0.43.x Compatibility

[alexanderbez]

Describe the bug

Startport fails to start chain on latest v0.43-rc3 SDK release.

To Reproduce

Steps to reproduce the behavior:

1. Clone umee branch
2. $ starport chain serve --reset-once -v -c ./starport.ci.yml
3. Observe:

[STARPORT] Cosmos SDK's version is: Stargate v0.40.0 (or later)
[STARPORT] 
[STARPORT] 🛠️  Building proto...
[STARPORT] 📦 Installing dependencies...
[STARPORT] 🛠️  Building the blockchain...
[STARPORT] 💿 Initializing the app...
...genesis...
[UMEE DAEMON] []{"name":"alice","type":"local","address":"umee1ps30nv2mxsrkkwn3p87ds9w99wtnd640ny0gtx","pubkey":"{\"@type\":\"/cosmos.crypto.secp256k1.PubKey\",\"key\":\"Ax7RcT/ELbw5UTazXuR3M3Kuk/gpIgP18n5iZOc5Iqtb\"}","mnemonic":"invite harbor skill text addict cute leisure force announce cricket game beyond lion breeze horror hen course game oil brush spawn giggle ring jungle"}
{"name":"alice","type":"local","address":"umee1ps30nv2mxsrkkwn3p87ds9w99wtnd640ny0gtx","pubkey":"{\"@type\":\"/cosmos.crypto.secp256k1.PubKey\",\"key\":\"Ax7RcT/ELbw5UTazXuR3M3Kuk/gpIgP18n5iZOc5Iqtb\"}","mnemonic":"invite harbor skill text addict cute leisure force announce cricket game beyond lion breeze horror hen course game oil brush spawn giggle ring jungle"}
EOF

My guess is that it might be related to cosmos/cosmos-sdk#9827. I'm not sure how Starport generates the gentxs, but it could be related to the expected input of --pubkey.

Please provide output of commands

• starport version

starport version v0.17.1 darwin/amd64 -build date: 2021-07-27T13:10:21Z

• go version

go version go1.16.2 darwin/amd64

• uname -a

Darwin abmacmini 20.2.0 Darwin Kernel Version 20.2.0: Wed Dec  2 20:39:59 PST 2020; root:xnu-7195.60.75~1/RELEASE_X86_64 x86_64 i386 Macmini8,1 Darwin

[fadeev]

Thanks for reporting! fwiw I'm getting:

panic: assignment to entry in nil map

goroutine 1 [running]:
github.com/cosmos/cosmos-sdk/x/params/types.Subspace.WithKeyTable(0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
	/Users/fadeev/go/pkg/mod/github.com/cosmos/cosmos-sdk@v0.42.4-0.20210623214207-eb0fc466c99b/x/params/types/subspace.go:59 +0x145
github.com/peggyjv/gravity-bridge/module/x/gravity/keeper.NewKeeper(0x5d37658, 0xc000f5b980, 0x5d07068, 0xc00018cf30, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
	/Users/fadeev/go/pkg/mod/github.com/peggyjv/gravity-bridge/module@v0.1.7/x/gravity/keeper/keeper.go:45 +0x325
github.com/umee-network/umee/app.New(0x5d228b8, 0xc00128a540, 0x5d393b8, 0xc00011e160, 0x0, 0x0, 0x1, 0xc000158510, 0x7ffeefbffbe1, 0x13, ...)
	/Users/fadeev/umee/app/app.go:321 +0x24c5
github.com/umee-network/umee/cmd/umeed/cmd.appCreator.newApp(0x5d2d908, 0xc00061ca38, 0x5d3ce18, 0xc000f5b980, 0x5d33b78, 0xc000619b40, 0xc000612ad0, 0x5d228b8, 0xc00128a540, 0x5d393b8, ...)
	/Users/fadeev/umee/cmd/umeed/cmd/app_creator.go:61 +0x9c5
github.com/cosmos/cosmos-sdk/server.startInProcess(0xc001001360, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x5d2aa68, 0xc000f5b980, ...)
	/Users/fadeev/go/pkg/mod/github.com/cosmos/cosmos-sdk@v0.42.4-0.20210623214207-eb0fc466c99b/server/start.go:236 +0x1eb
github.com/cosmos/cosmos-sdk/server.StartCmd.func2(0xc000feea00, 0xc00108a420, 0x0, 0x6, 0x0, 0x0)
	/Users/fadeev/go/pkg/mod/github.com/cosmos/cosmos-sdk@v0.42.4-0.20210623214207-eb0fc466c99b/server/start.go:120 +0x1c8
github.com/spf13/cobra.(*Command).execute(0xc000feea00, 0xc00108a360, 0x6, 0x6, 0xc000feea00, 0xc00108a360)
	/Users/fadeev/go/pkg/mod/github.com/spf13/cobra@v1.1.3/command.go:852 +0x472
github.com/spf13/cobra.(*Command).ExecuteC(0xc00066d900, 0x0, 0x0, 0xc000620f00)
	/Users/fadeev/go/pkg/mod/github.com/spf13/cobra@v1.1.3/command.go:960 +0x375
github.com/spf13/cobra.(*Command).Execute(...)
	/Users/fadeev/go/pkg/mod/github.com/spf13/cobra@v1.1.3/command.go:897
github.com/spf13/cobra.(*Command).ExecuteContext(...)
	/Users/fadeev/go/pkg/mod/github.com/spf13/cobra@v1.1.3/command.go:890
github.com/cosmos/cosmos-sdk/server/cmd.Execute(0xc00066d900, 0xc000620f00, 0x13, 0x5d3ce18, 0xc000f5b980)
	/Users/fadeev/go/pkg/mod/github.com/cosmos/cosmos-sdk@v0.42.4-0.20210623214207-eb0fc466c99b/server/cmd/execute.go:36 +0x265
main.main()
	/Users/fadeev/umee/cmd/umeed/main.go:13 +0x45

[alexanderbez]

	/Users/fadeev/go/pkg/mod/github.com/peggyjv/gravity-bridge/module@v0.1.7/x/gravity/keeper/keeper.go:45 +0x325
github.com/umee-network/umee/app.New(0x5d228b8, 0xc00128a540, 0x5d393b8, 0xc00011e160, 0x0, 0x0, 0x1, 0xc000158510, 0x7ffeefbffbe1, 0x13, ...)
	/Users/fadeev/umee/app/app.go:321 +0x24c5

This doesn't look right. It's using a really old version (v0.1.7). Are you sure you're trying on the bez/8-update-deps branch? it should be using 0.1.18 of the gravity bridge.

[fadeev]

Yeah, sorry, must've switched back to main. Can reproduce the same issue as you reported.

[alexanderbez]

This could have nothing to do with cosmos/cosmos-sdk#9827. It could just be general v0.43 support.

[faddat]

@alexanderbez it is. I think it is very simple, changing a struct. If only I could find the correct struct, I think it is where starport init grabs output from the chain.

May touch on this later today.

[ilgooz]

This is fixed by #1455.

But now starport fails while running the gentx command because it does not follow the standard arguments:

umeed gentx [key_name] [amount] [eth-address] [orchestrator-address] [eth-sig] [flags]

[alexanderbez]

Thanks for the fix @ilgooz!

Unfortunate about gentx, but I guess it's not trivial to support custom application variants of the command. What I can do in this case for Umee is to have two flavors of the gentx command, where Starport will use the vanilla/standard version.

[alexanderbez]

Feel free to close this issue once #1455 is merged. When can we expect the next release?

[alexanderbez]

@ilgooz I've made a gentx command change on bez/gentx-vanilla main. Can you pull this branch and try your changes against that please?

[ilgooz]

@alexanderbez hey! Yes, it works after your updates. If you need the fix to be available soon, maybe we can make a dedicated point release for it cc @fadeev. Otherwise, you can expect to see a new release someday next week.

[fadeev]

Yeah, if it's urgent, we can do a point release, otherwise, v0.17.2 next week.

[alexanderbez]

Not urgent. Thanks @fadeev :)

[fadeev]

Done!