Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor (components): components used to render svg can be functional components. #268

Open
atharva3010 opened this issue Apr 29, 2022 · 0 comments
Open

refactor (components): components used to render svg can be functional components. #268

atharva3010 opened this issue Apr 29, 2022 · 0 comments

Comments

@atharva3010
Copy link

atharva3010 commented Apr 29, 2022 •
edited
Loading

Hello everyone 👋

I was looking at the components under the directory /packages/vue and found that there are SFCs that only render an SVG icon.

Some examples of this are:

Changing them to functional components will improve performance as these will be treated as stateless, without any component instance, HTML.

If you choose to acknowledge this issue, I'd be happy to create a PR fixing this.
@atharva3010 atharva3010 changed the title refactor (components): components used to render svg can j refactor (components): components used to render svg can be functional components. Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@atharva3010