Build fails with tinyxml2 6.0

[osrf-migration]

Original report (archived issue) by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).

---

Tinyxml2 version 6.0.0 was released into homebrew recently and has some API changes that cause build failures of ignition-common:

• https://build.osrfoundation.org/view/os_homebrew/job/ignition_common-ci-default-homebrew-amd64/89

/Users/jenkins/workspace/ignition_common-ci-default-homebrew-amd64/ign-common/src/ColladaExporter.cc:44:32: error: no member named 'GetErrorStr1' in 'tinyxml2::XMLDocument'; did you mean 'ErrorStr'?
    const char * error1 = _doc.GetErrorStr1();
                               ^~~~~~~~~~~~
                               ErrorStr
/usr/local/Cellar/tinyxml2/6.0.0/include/tinyxml2.h:1814:14: note: 'ErrorStr' declared here
        const char* ErrorStr() const;
                    ^
/Users/jenkins/workspace/ignition_common-ci-default-homebrew-amd64/ign-common/src/ColladaExporter.cc:45:32: error: no member named 'GetErrorStr2' in 'tinyxml2::XMLDocument'; did you mean 'ErrorStr'?
    const char * error2 = _doc.GetErrorStr2();
                               ^~~~~~~~~~~~
                               ErrorStr
/usr/local/Cellar/tinyxml2/6.0.0/include/tinyxml2.h:1814:14: note: 'ErrorStr' declared here
        const char* ErrorStr() const;
                    ^
2 errors generated.

I think we'll need some ifdefs because the functions have been renamed.

[osrf-migration]

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).

---

The API changes came from here:

• leethomason/tinyxml2@f49b965#diff-f0c986b0c387a2c34d4d6232c8d8c86b

[osrf-migration]

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).

---

see pull request #87

[osrf-migration]

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).

---

• changed state from "new" to "resolved"

pull request #87