Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Segfault when parsing incorrect SDF. #590

Closed
Mokosha opened this issue Jun 11, 2021 · 1 comment · Fixed by #610
Closed

Segfault when parsing incorrect SDF. #590

Mokosha opened this issue Jun 11, 2021 · 1 comment · Fixed by #610
Assignees
@aaronchongth
Labels
bug Something isn't working

Comments

@Mokosha
Copy link

Mokosha commented Jun 11, 2021

elemXml may be undefined on this line since the loop prior to it terminates on it being nullptr:

https://github.com/osrf/sdformat/blob/85ebd9ba6774d1cdc89f9f03ab98da4d43267442/src/parser.cc#L1502
@azeey
Copy link
Collaborator

azeey commented Jun 25, 2021

Yeah, I think we should be using _sdf->LineNumber() instead.

@azeey azeey added the bug Something isn't working label Jun 25, 2021
@aaronchongth aaronchongth mentioned this issue Jun 29, 2021
Merged
7 tasks
@azeey azeey mentioned this issue Jul 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aaronchongth aaronchongth

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix segfault when checking for required elements in joint gazebosim/sdformat
3 participants
@azeey @Mokosha @aaronchongth