Skip to content

Fix joint parent/child frame existence checks to include interface elements #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 22, 2022

Conversation

azeey
Copy link
Collaborator

@azeey azeey commented Feb 18, 2022

🦟 Bug fix

Summary

Names in //joint/parent or //joint/child that reference frames inside a nested model that was included via the Interface API cause errors when loading a model. I believe this is a regression that was introduced when fixing #719 via #727.

9b8a2bd adds a failing test showing the regression with the following failure message:

Value of: errors.empty()
  Actual: false
Expected: true
Error Code 19: Msg: child frame with name[double_pendulum::base] specified by joint with name[J1] not found in model with name[parent_model].
Error Code 20: Msg: parent frame with name[double_pendulum::child_dp::base] specified by joint with name[J2] not found in model with name[parent_model].

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
…ements

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey requested a review from scpeters as a code owner February 18, 2022 21:14
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Feb 18, 2022
@azeey azeey self-assigned this Feb 18, 2022
@azeey azeey changed the title Fix joint frame check Fix joint parent/child frame existence checks to include interface elements Feb 18, 2022
@azeey azeey merged commit 82ba371 into gazebosim:sdf11 Feb 22, 2022
@azeey azeey deleted the fix_joint_frame_check branch February 22, 2022 16:57
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-25-fortress-edifice-citadel/1343/1

@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants