Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colorpicker enhancements regarding popup dismissal and landscape mode #32

Closed
anordvall opened this issue Jan 11, 2016 · 6 comments
Closed
Labels
Milestone

Comments

@anordvall
Copy link

Two suggested low prio enhandcements to the colorpicker:

  • Click anywhere outside the popup should close the color picker
  • In landscape view on a normal phone, the actual palette gets really small

Suggestion to fix the second item is to move the Close button (or remove it completely if first item is implemented) and/or to make the brightness slider vertical and Place it on the right side of the palette

@igorgladkov
Copy link
Owner

Clicking outside popup does close it for me (tried on few different devices).
Does it not close any popup in the app for you?

@anordvall
Copy link
Author

No it doesn't. I've tried with the color picker popup, the theme selector popup and Voice Command Item setting popup. None of them close when clicking outside.

@igorgladkov
Copy link
Owner

What device/OS?

@anordvall
Copy link
Author

Samsung Galaxy S4 with Android 5.0.1

@igorgladkov
Copy link
Owner

Created new issue for palette size: #33

@igorgladkov igorgladkov added this to the 0.2.18 milestone Jan 11, 2016
@anordvall
Copy link
Author

Verified that the color picker popup can now be closed. Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants