Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backdrop improvement: Add url for vertical and horizontal orientation #55

Closed
frode opened this issue Jan 21, 2016 · 11 comments
Closed

Backdrop improvement: Add url for vertical and horizontal orientation #55

frode opened this issue Jan 21, 2016 · 11 comments
Milestone

Comments

@frode
Copy link

frode commented Jan 21, 2016

Add two url options example:

Image label="{item:backdrop}" vertical-url="https://source.unsplash.com/category/nature/1080x1920, horizontal-url="https://source.unsplash.com/category/nature/1920x1080"

And automatically use the correct one for the current orientation 👍

url as it is in the current version could be used as a fallback if none of the orientations were specified.

@igorgladkov
Copy link
Owner

Are you using backdrop on a phone or handheld tablet?

@d0t101101
Copy link

I'm using Rotini on all my devices, and would also like to see this proposed feature to switch the image based on orientation (mostly for Phone's).

@igorgladkov
Copy link
Owner

@frode, @d0t101101 To restate my question, are you using the same sitemap with backdrop on all devices (phones and tablets)?

@d0t101101
Copy link

Yes, I am... Portriat mode truncates the backdrop image on both.

@frode
Copy link
Author

frode commented Jan 22, 2016

@igorgladkov I use one sitemap on both phone and tablet, and will make a dedicated table sitemap later when you release a android 4.x compatible app, or when I've purchased a newer tablet for the purpose.

@igorgladkov igorgladkov added this to the 0.3.26 milestone Feb 1, 2016
@igorgladkov
Copy link
Owner

Added in 0.3.26

@frode
Copy link
Author

frode commented Feb 1, 2016

@igorgladkov Well done, any info om usage?

@igorgladkov
Copy link
Owner

@frode Will update the wiki closer to release time

@frode
Copy link
Author

frode commented Feb 1, 2016

@igorgladkov A bit early in the morning here, not completed my first coffee cup yet. Thanks, release numbers slipped my eyes.

@d0t101101
Copy link

@igorgladkov - thanks for the new feature! Tested and working fine. A potential feature improvement around this - can you parameterize the devices width/height? This way the resolution can be detected by Rotini and passed in as variables to the image URL, so the same sitemap would be pixel perfect on many devices...

For example:

Image label="{item:backdrop}" vertical-url="https://source.unsplash.com/category/nature/{device:width}x{device:height}"

@igorgladkov
Copy link
Owner

@d0t101101 I would say just set the highest resolution you need from all your devices and it will be down-sampled whenever required, which should not have any quality loss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants