Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not expose private types from libraries #176

Closed
igorkamyshev opened this issue Nov 22, 2022 · 0 comments · Fixed by #184 or #174
Closed

Do not expose private types from libraries #176

igorkamyshev opened this issue Nov 22, 2022 · 0 comments · Fixed by #184 or #174
Labels
BREAKING CHANGES scope:core type:bug Something isn't working

Comments

@igorkamyshev
Copy link
Owner

It's possible to use smth like this

import { FetchingStatus } from '@farfetched/core/src/status/type';

because we do not bundle type definitions in the single file. So, we have to find a way to ban such imports 🤗
This was referenced Nov 24, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BREAKING CHANGES scope:core type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not expose types igorkamyshev/farfetched
Release 0.4 igorkamyshev/farfetched
1 participant
@igorkamyshev