Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension breaks 3d.laingame.net #1162

Open
mskiptr opened this issue Dec 17, 2024 · 0 comments
Open

Extension breaks 3d.laingame.net #1162

mskiptr opened this issue Dec 17, 2024 · 0 comments

Comments

@mskiptr
Copy link

mskiptr commented Dec 17, 2024

The website https://3d.laingame.net/ is subtly broken when used with this extension's default configuration. The "game" contains several short videos which this extension picks up. At the same time the game's default key bindings include x (or ) for 'confirm' and z (or ) for 'back' which clashes with the extension's default bindings for 'advance' and 'rewind'. This results in most in-game videos starting incorrectly and probably causes some other glitches I've been observing. There could also be some race conditions at play here (could the extension be catching some of the key presses and so prevent the game from picking them up?).

At first I wasn't sure if these were bugs in the WebGL reimplementation or maybe even intended behavior based on the original PlayStation game. It took me noticing that the controller UI shows up on those in-game videos and then connecting the dots to figure out what was going on. After that, to resolve the problem I just added laingame.net to the list of "sites on which extension is disabled" in the settings. What I'm trying to say is it's really not that obvious. It would help a lot if the extension could avoid this problem out of the box.

One solution would be to have laingame.net in the exclusion list by default (or have it always be excluded since the game using HTML5 videos is just an implementation detail). If that's the best course of action I could probably prepare a patch. On the other hand maybe there's a deeper issue here. Would it be possible to detect if a website uses the same keybindings as the extension and deal with this clash somehow? But also there are quite a lot of websites using HTML5 video for stuff other than regular video playback. In such case the controller UI showing up can be quite annoying. If the extension could exclude all such cases automatically it would be be a pretty nice improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant