-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support picture-in-picture #441
Comments
Interesting idea. Paging @beaufortfrancois for thoughts and opinions :-) |
I agree with @vapier that it's not in the scope of the extension but I'd be happy to review a PR if needed. In the mean time, we also have published Picture-in-Picture Extension (by Google) |
Ah, perfect. If there is an official extension for this.. let's defer to that! Thanks! |
i'm aware of the pip extension, but my suggestion for this was due to:
so if people are amenable to it, i'd be happy to post a PR for this extension |
Hmm, I guess I'm not familiar enough with the implementation but this sounds like a good feature request for the official extension?
I hear ya, but the ongoing cost of maintenance is a real burden. I would rather do one thing well, which is already keeping us plenty busy here, than multiple things poorly. |
i know it doesn't exactly fit in with the scope of this extension, but how do you feel about adding support for toggling picture-in-picture ? most sites don't support this, especially as it's not been implemented in other agents yet. Chrome 70 shipped it though.
all you have to do is call the video element's
requestPictureInPicture()
method.The text was updated successfully, but these errors were encountered: