Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support picture-in-picture #441

Closed
vapier opened this issue Mar 25, 2019 · 5 comments
Closed

support picture-in-picture #441

vapier opened this issue Mar 25, 2019 · 5 comments

Comments

@vapier
Copy link

vapier commented Mar 25, 2019

i know it doesn't exactly fit in with the scope of this extension, but how do you feel about adding support for toggling picture-in-picture ? most sites don't support this, especially as it's not been implemented in other agents yet. Chrome 70 shipped it though.

all you have to do is call the video element's requestPictureInPicture() method.

@igrigorik
Copy link
Owner

Interesting idea. Paging @beaufortfrancois for thoughts and opinions :-)

@beaufortfrancois
Copy link

I agree with @vapier that it's not in the scope of the extension but I'd be happy to review a PR if needed.

In the mean time, we also have published Picture-in-Picture Extension (by Google)
for this specific use case.

@igrigorik
Copy link
Owner

Ah, perfect. If there is an official extension for this.. let's defer to that! Thanks!

@vapier
Copy link
Author

vapier commented Mar 25, 2019

i'm aware of the pip extension, but my suggestion for this was due to:

  • the pip extension operates at the page level rather than per-video
  • it's one fewer extension i need to install ;)
  • one fewer extension that needs to crawl the dom looking for video tags to expose custom UI

so if people are amenable to it, i'd be happy to post a PR for this extension

@igrigorik
Copy link
Owner

  • the pip extension operates at the page level rather than per-video

Hmm, I guess I'm not familiar enough with the implementation but this sounds like a good feature request for the official extension?

  • it's one fewer extension i need to install ;)
  • one fewer extension that needs to crawl the dom looking for video tags to expose custom UI

I hear ya, but the ongoing cost of maintenance is a real burden. I would rather do one thing well, which is already keeping us plenty busy here, than multiple things poorly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants