Protect against buggy participants reports from Aalto SISU API

Fixes apluslms#1180

Author: ihalaij1

course/models.py

@@ -24,6 +24,7 @@
 from django.utils.text import format_lazy
 from django.utils.translation import gettext_lazy as _
 from django_colortag.models import ColorTag
+from requests.exceptions import HTTPError
 
 from apps.models import BaseTab, BasePlugin
 from authorization.models import JWTAccessible
@@ -915,7 +916,7 @@ def enroll_student(self, user, from_sis=False, use_pending=False):
                 return True
         return False
 
-    def enroll_from_sis(self) -> Tuple[int, int]:
+    def enroll_from_sis(self) -> Tuple[int, int]: # pylint: disable=too-many-locals
         """
         Enroll students based on the participants information in Student Info System.
         If student has removed herself in SIS, she will also be marked as removed in A+.
@@ -935,9 +936,12 @@ def enroll_from_sis(self) -> Tuple[int, int]:
         delcount = 0
         try:
             participants = sis.get_participants(self.sis_id)
+        except HTTPError as exc:
+            code = exc.response.status_code
+            logger.exception("%s: Error %d when getting participants from SIS.", self, code)
+            return -1, -1
         except Exception:
-            # pylint: disable-next=logging-fstring-interpolation
-            logger.exception(f"{self}: Error in getting participants from SIS.")
+            logger.exception("%s: Error in getting participants from SIS.", self)
             return -1, -1
 
         from exercise.models import LearningObject # pylint: disable=import-outside-toplevel
@@ -954,19 +958,23 @@ def enroll_from_sis(self) -> Tuple[int, int]:
                 # yet logged in to A+, then the user profile does not exist yet.
                 pass
 
-        # Remove SIS-enrolled students who are not anymore in SIS participants,
-        # for example, because they have first enrolled in SIS, but then
-        # unenrolled themselves.
-        students = self.all_students.filter(enrollment__from_sis=True)
-        to_remove = students.exclude(student_id__in=participants)
-        qs = Enrollment.objects.filter(user_profile__in=to_remove, course_instance=self)
-        qs.update(status=Enrollment.ENROLLMENT_STATUS.REMOVED)
-        for e in qs:
-            invalidate_content(Enrollment, e)
-            delcount += 1
-
-        # pylint: disable-next=logging-fstring-interpolation
-        logger.info(f"{self}: enrolled {addcount}, removed {delcount} students based on SIS")
+        # Ignore empty participants list caused by a rare SIS API gateway malfunction
+        if participants:
+            # Remove SIS-enrolled students who are not anymore in SIS participants,
+            # for example, because they have first enrolled in SIS, but then
+            # unenrolled themselves.
+            students = self.all_students.filter(enrollment__from_sis=True)
+            to_remove = students.exclude(student_id__in=participants)
+            qs = Enrollment.objects.filter(user_profile__in=to_remove, course_instance=self)
+            qs.update(status=Enrollment.ENROLLMENT_STATUS.REMOVED)
+            for e in qs:
+                invalidate_content(Enrollment, e)
+                delcount += 1
+        else:
+            logger.warning("%s: Received an empty participants list from SIS.", self)
+            return 0, 0
+
+        logger.info("%s: enrolled %d, removed %d students based on SIS", self, addcount, delcount)
         return addcount, delcount
 
     def set_users_with_role(self, users, role, remove_others_with_role=False):