-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
netcdf CF convections #9
Comments
@sadielbartholomew I read about the Regarding Point 2, the standard_names for the u- and v- flux components are indeed, as you said, Regarding Point 1, the If I understand correctly, there exists a pre-defined, permissible list of |
@Xunius a couple of follow on points about this:
Also 👍 👍 to @sadielbartholomew for such a thorough comment on CF-compliance and standard names. 🚀 |
This is copying from comments made by @sadielbartholomew. See original post at openjournals/joss-reviews#2407 (comment).
Continuing on the topic of improvements that are not compulsory towards acceptance in the paper given the open criteria, but would be good to think about going forwards, for good practice with metadata I suggest making more use of the CF Conventions (the recommended standard for netCDF), namely as described in the three points below.
uflux_s_6_1984_Jan.nc
&vflux_s_6_1984_Jan.nc
provided there are marked by global attribute as being CF-compliant to CF 1.6:which is okay (relative to the ideal, latest version, 1.8), but immediately I see improvements in compliance that could be made.
For example, the variable & dimensions are all described by a
long_name
attribute, where use of astandard_name
attribute is preferable as each is unambiguous (see e.g. here). The time, lat & lon coordinates can take standard names of the same identifier as currently used for the long name, and from a quick search on the names table for "eastward" AND "vapor" I think the data itself withlong_name=Vertical integral of eastward water vapour flux
and unitskg m**-1 s**-1
could probably be assigned astandard name
ofeastward_atmosphere_water_vapor_transport_across_unit_distance
, or similar.you could explicitly state the standard names of data variables which would be applicable, e.g. something similar to
northward_
... andeastward_atmosphere_water_vapor_transport_across_unit_distance
and maybe link to the definition of all grids which may be considered rectangular, for clarity. This would make it crystal clear whether a user's dataset(s) may be appropriate for processing by IPART.So, you are advocating that users define data dimensions in the inverse order to that recommended. To make IPART more immediately accessible, you could amend your code so that it accepts the outlined conventional order, rather than the inverse.
The text was updated successfully, but these errors were encountered: